lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 25 Jul 2020 19:39:50 +0200 From: Marek Behun <marek.behun@....cz> To: Andrew Lunn <andrew@...n.ch> Cc: Pavel Machek <pavel@....cz>, netdev@...r.kernel.org, linux-leds@...r.kernel.org, jacek.anaszewski@...il.com, Dan Murphy <dmurphy@...com>, Ondřej Jirman <megous@...ous.com>, Russell King <linux@...linux.org.uk>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, Gregory Clement <gregory.clement@...tlin.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH RFC leds + net-next v3 2/2] net: phy: marvell: add support for PHY LEDs via LED class On Sat, 25 Jul 2020 17:03:42 +0200 Andrew Lunn <andrew@...n.ch> wrote: > Does hi-z mean off? In the implementation i did, i did not list off > and on as triggers. I instead used them for untriggered > brightness. That allowed the software triggers to work, so i had the > PHY blinking the heartbeat etc. But i had to make it optional, since a > quick survey of datasheets suggested not all PHYs support simple > on/off control. I don't actually know what hi-z means, but enabling it disabled the LED. But there is another register value for OFF... > Something beyond the scope of this patchset is implementing etHool -p > > -p --identify > Initiates adapter-specific action intended to enable an operator to > easily identify the adapter by sight. Typically this involves blink‐ > ing one or more LEDs on the specific network port. > > If we have software controlled on/off, then a software trigger seems > like i good way to do this. I'll look into this. Marek
Powered by blists - more mailing lists