netdev - Re: [PATCH][V2] sctp: remove redundant initialization of variable status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 24 Jul 2020 17:10:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     vyasevich@...il.com, nhorman@...driver.com,
        marcelo.leitner@...il.com, kuba@...nel.org,
        linux-sctp@...r.kernel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] sctp: remove redundant initialization of variable
 status

From: Colin King <colin.king@...onical.com>
Date: Fri, 24 Jul 2020 14:09:19 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable status is being initialized with a value that is never read
> and it is being updated later with a new value.  The initialization is
> redundant and can be removed.  Also put the variable declarations into
> reverse christmas tree order.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
> ---
> 
> V2: put variable declarations into reverse christmas tree order.

Applied to net-next, thanks.