netdev - Re: [Patch net v2] qrtr: orphan socket in qrtr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200724.173127.26127623570599068.davem@davemloft.net>
Date:   Fri, 24 Jul 2020 17:31:27 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org,
        syzbot+6720d64f31c081c2f708@...kaller.appspotmail.com,
        bjorn.andersson@...aro.org, eric.dumazet@...il.com
Subject: Re: [Patch net v2] qrtr: orphan socket in qrtr_release()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Fri, 24 Jul 2020 09:45:51 -0700

> We have to detach sock from socket in qrtr_release(),
> otherwise skb->sk may still reference to this socket
> when the skb is released in tun->queue, particularly
> sk->sk_wq still points to &sock->wq, which leads to
> a UAF.
> 
> Reported-and-tested-by: syzbot+6720d64f31c081c2f708@...kaller.appspotmail.com
> Fixes: 28fb4e59a47d ("net: qrtr: Expose tunneling endpoint to user space")
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied and queued up for -stable, thanks.