netdev - Re: [PATCH net-next v4 1/2] hinic: add support to handle hw abnormal event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aa6e490a-2c02-5deb-0df5-ed6dab0f7c8b@huawei.com>
Date:   Sat, 25 Jul 2020 09:19:33 +0800
From:   "luobin (L)" <luobin9@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <luoxianjun@...wei.com>, <yin.yinshi@...wei.com>,
        <cloud.wangxiaoyun@...wei.com>, <chiqijun@...wei.com>
Subject: Re: [PATCH net-next v4 1/2] hinic: add support to handle hw abnormal
 event

On 2020/7/25 8:04, David Miller wrote:
> From: Luo bin <luobin9@...wei.com>
> Date: Fri, 24 Jul 2020 17:17:31 +0800
> 
>> +static int hinic_fw_reporter_dump(struct devlink_health_reporter *reporter,
>> +				  struct devlink_fmsg *fmsg, void *priv_ctx,
>> +				  struct netlink_ext_ack *extack)
>> +{
>> +	int err;
>> +
>> +	if (priv_ctx) {
>> +		err = mgmt_watchdog_report_show(fmsg, priv_ctx);
>> +		if (err)
>> +			return err;
>> +	}
>> +
>> +	return 0;
>> +}
> 
> As Edward Cree pointed out for v3 of this patch series, this 'err' is not
> necessary at all.
> .
> 
Will fix. Thanks.