lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 24 Jul 2020 19:44:17 -0700 (PDT)
From:   David Miller <>
Subject: Re: [PATCH net-next 2/4] ionic: recover from ringsize change

From: Shannon Nelson <>
Date: Fri, 24 Jul 2020 17:23:24 -0700

> If the ringsize change fails, try restoring the previous setting.
> Signed-off-by: Shannon Nelson <>

You really can't recover properly, or reliably, with the way all of this
is structured in the ionic driver.  This is at best a half attempt at
error recovery.

Doing a full ionic_open() call abstracts things too heavily.

What you need to do is save away the current queue memory and object,
without freeing them, and only release them when you can successfully
setup the new queues.

This is the only way you can properly recover from errors in this
operation, with a proper check/commit sequence.

I'd rather not merge half solutions to this problem, sorry.

Powered by blists - more mailing lists