[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200724.201037.91669607453014965.davem@davemloft.net>
Date: Fri, 24 Jul 2020 20:10:37 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: sundeep.lkml@...il.com
Cc: kuba@...nel.org, netdev@...r.kernel.org, sgoutham@...vell.com,
sbhatta@...vell.com
Subject: Re: [PATCH net 0/3] Fix bugs in Octeontx2 netdev driver
From: sundeep subbaraya <sundeep.lkml@...il.com>
Date: Fri, 24 Jul 2020 08:40:44 +0530
> On Fri, Jul 24, 2020 at 12:43 AM David Miller <davem@...emloft.net> wrote:
>>
>> If you leave interrupts on then an interrupt can arrive after the software
>> state has been released by unregister_netdev.
>>
>> Sounds like you need to resolve this some other way.
>
> Only mailbox interrupts can arrive after unregister_netdev since
> otx2_stop disables
> the packet I/O and its interrupts as the first step.
> And mbox interrupts are turned off after unregister_neetdev.
> unregister_netdev(netdev);
> otx2vf_disable_mbox_intr(vf);
Please explain this in your commit message.
Thank you.
Powered by blists - more mailing lists