netdev - Re: [PATCH v1 0/2] ptp: Add generic header parsing function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871rl0nkhn.fsf@kurt>
Date:   Sat, 25 Jul 2020 09:04:36 +0200
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     Richard Cochran <richardcochran@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 0/2] ptp: Add generic header parsing function

On Fri Jul 24 2020, Richard Cochran wrote:
> On Fri, Jul 24, 2020 at 08:25:59AM +0200, Kurt Kanzenbach wrote:
>> |static inline u8 ptp_get_msgtype(const struct ptp_header *hdr, unsigned int type)
>> |{
>> |	u8 msg;
>> |
>> |	if (unlikely(type & PTP_CLASS_V1))
>> |		/* msg type is located @ offset 20 for ptp v1 */ 
>> |		msg = hdr->source_port_identity.clock_identity.id[0];
>> |	else
>> |		msg = hdr->tsmt & 0x0f;
>> |
>> |	return msg;
>> |}
>> 
>> What do you think about it?
>
> Looks good.

OK, I'll add it.

>
> I can also test the dp83640.  Maybe you could test the cpts on a bbb?

Most likely, yes.

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)