netdev - Re: [PATCH] ipv6: Fix nexthop reference count in ip6_route_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2ac42db4-96e1-298d-4100-beb95d7c91e1@web.de>
Date:   Sat, 25 Jul 2020 11:34:07 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Xiyu Yang <xiyuyang19@...an.edu.cn>,
        Xin Tan <tanxin.ctf@...il.com>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        "David S. Miller" <davem@...emloft.net>,
        Hideaki Yoshifuji <yoshfuji@...ux-ipv6.org>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH] ipv6: Fix nexthop reference count in
 ip6_route_info_create()

…
> When ip6_route_info_create() returns, local variable "nh" becomes
> invalid, so the refcount should be decreased to keep refcount balanced.

Can it be helpful to use the term “reference count” in consistent ways?


> Fix this issue

How do you think about to replace this wording by the tag “Fixes”?


>                by pulling up the error source routing handling when
> nexthops can not be used with source routing.

Does the movement of an if statement according to the check of the
data structure member “rt->fib6_src.plen” in an if branch really help here?

Regards,
Markus