netdev - Re: [RFC PATCH ipsec] xfrm: don't pass too short packets to userspace with ESPINUDP encap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <6FEDD2D2-CBA1-41E8-85B8-0180EFB4738E@nohats.ca>
Date:   Mon, 27 Jul 2020 07:07:24 -0400
From:   Paul Wouters <paul@...ats.ca>
To:     Steffen Klassert <steffen.klassert@...unet.com>
Cc:     Sabrina Dubroca <sd@...asysnail.net>, netdev@...r.kernel.org,
        Andrew Cagney <andrew.cagney@...il.com>,
        Tobias Brunner <tobias@...ongswan.org>
Subject: Re: [RFC PATCH ipsec] xfrm: don't pass too short packets to userspace with ESPINUDP encap

On Jul 27, 2020, at 05:28, Steffen Klassert <steffen.klassert@...unet.com> wrote:
> 
> 
>> 
>> This patch changes that behavior, so that only properly-formed non-ESP
>> messages are passed to userspace. Messages of 8 bytes or less that
>> don't contain a full non-ESP prefix followed by some data (at least
>> one byte) will be dropped and counted as XfrmInHdrError.
> 
> I'm ok with that change. But it affects userspace, so the *swan
> people have to tell if that's ok for them.


Libreswan is okay with this, we actually discussed this with Sabrina as a result of the TCP work where she noticed the difference.

Paul