lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 27 Jul 2020 03:38:20 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:     Fugang Duan <fugang.duan@....com>, davem@...emloft.net,
        netdev@...r.kernel.org, cphealy@...il.com,
        martin.fuzzey@...wbird.group
Subject: Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net:
 ethernet: fec: Replace interrupt driven MDIO with polled IO"

On Mon, Jul 27, 2020 at 04:23:54AM +0300, Laurent Pinchart wrote:
> Hi Fugang,
> 
> On Mon, Apr 27, 2020 at 10:08:04PM +0800, Fugang Duan wrote:
> > This reverts commit 29ae6bd1b0d8a57d7c00ab12cbb949fc41986eef.
> > 
> > The commit breaks ethernet function on i.MX6SX, i.MX7D, i.MX8MM,
> > i.MX8MQ, and i.MX8QXP platforms. Boot yocto system by NFS mounting
> > rootfs will be failed with the commit.
> 
> I'm afraid this commit breaks networking on i.MX7D for me :-( My board
> is configured to boot over NFS root with IP autoconfiguration through
> DHCP. The DHCP request goes out, the reply it sent back by the server,
> but never noticed by the fec driver.
> 
> v5.7 works fine. As 29ae6bd1b0d8a57d7c00ab12cbb949fc41986eef was merged
> during the v5.8 merge window, I suspect something else cropped in
> between 29ae6bd1b0d8a57d7c00ab12cbb949fc41986eef and this patch that
> needs to be reverted too. We're close to v5.8 and it would be annoying
> to see this regression ending up in the released kernel. I can test
> patches, but I'm not familiar enough with the driver (or the networking
> subsystem) to fix the issue myself.

Hi Laurent

We had a few reverts and reverts of reverts etc. But in the end it
seemed to work fine for a range of boards/SoCs.

What exactly are you testing here? v5.8-rc7?

Thanks
	Andrew

Powered by blists - more mailing lists