netdev - Re: [PATCH net-next 2/4] ionic: recover from ringsize change failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5cf99807-2362-cec0-dbad-8f23ba627b04@pensando.io>
Date:   Mon, 27 Jul 2020 09:42:00 -0700
From:   Shannon Nelson <snelson@...sando.io>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/4] ionic: recover from ringsize change failure

On 7/24/20 7:44 PM, David Miller wrote:
> From: Shannon Nelson <snelson@...sando.io>
> Date: Fri, 24 Jul 2020 17:23:24 -0700
>
>> If the ringsize change fails, try restoring the previous setting.
>>
>> Signed-off-by: Shannon Nelson <snelson@...sando.io>
> You really can't recover properly, or reliably, with the way all of this
> is structured in the ionic driver.  This is at best a half attempt at
> error recovery.
>
> Doing a full ionic_open() call abstracts things too heavily.
>
> What you need to do is save away the current queue memory and object,
> without freeing them, and only release them when you can successfully
> setup the new queues.
>
> This is the only way you can properly recover from errors in this
> operation, with a proper check/commit sequence.
>
> I'd rather not merge half solutions to this problem, sorry.

Sure, thanks anyway.
sln