lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Jul 2020 10:10:59 -0700 (PDT) From: David Miller <davem@...emloft.net> To: Julia.Lawall@...ia.fr Cc: saeedm@...lanox.com, kernel-janitors@...r.kernel.org, leon@...nel.org, kuba@...nel.org, netdev@...r.kernel.org, linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 4/7] net/mlx5: drop unnecessary list_empty From: Julia Lawall <Julia.Lawall@...ia.fr> Date: Sun, 26 Jul 2020 12:58:29 +0200 > list_for_each_entry is able to handle an empty list. > The only effect of avoiding the loop is not initializing the > index variable. > Drop list_empty tests in cases where these variables are not > used. > > Note that list_for_each_entry is defined in terms of list_first_entry, > which indicates that it should not be used on an empty list. But in > list_for_each_entry, the element obtained by list_first_entry is not > really accessed, only the address of its list_head field is compared > to the address of the list head, so the list_first_entry is safe. > > The semantic patch that makes this change is as follows (with another > variant for the no brace case): (http://coccinelle.lip6.fr/) ... > Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr> Saeed, please pick this up. Thank you.
Powered by blists - more mailing lists