netdev - Re: [PATCH net-next] ipmr: Copy option to correct variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200727.114025.2171832003961398268.davem@davemloft.net>
Date:   Mon, 27 Jul 2020 11:40:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...lanox.com
Cc:     netdev@...r.kernel.org, kuba@...nel.org, hch@....de,
        mlxsw@...lanox.com
Subject: Re: [PATCH net-next] ipmr: Copy option to correct variable

From: Ido Schimmel <idosch@...lanox.com>
Date: Mon, 27 Jul 2020 10:18:34 +0300

> Cited commit mistakenly copied provided option to 'val' instead of to
> 'mfc':
> 
> ```
> -               if (copy_from_user(&mfc, optval, sizeof(mfc))) {
> +               if (copy_from_sockptr(&val, optval, sizeof(val))) {
> ```
> 
> Fix this by copying the option to 'mfc'.
> 
> selftest router_multicast.sh before:
 ...
> selftest router_multicast.sh after:
 ...
> Fixes: 01ccb5b48f08 ("net/ipv4: switch ip_mroute_setsockopt to sockptr_t")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>

Applied, thank you.