netdev - Re: [PATCH net] mptcp: fix joined subflows with unblocking sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200727.115218.1191292272155021831.davem@davemloft.net>
Date:   Mon, 27 Jul 2020 11:52:18 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     matthieu.baerts@...sares.net
Cc:     netdev@...r.kernel.org, mathew.j.martineau@...ux.intel.com,
        kuba@...nel.org, pabeni@...hat.com, mptcp@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] mptcp: fix joined subflows with unblocking sk

From: Matthieu Baerts <matthieu.baerts@...sares.net>
Date: Mon, 27 Jul 2020 12:24:33 +0200

> Unblocking sockets used for outgoing connections were not containing
> inet info about the initial connection due to a typo there: the value of
> "err" variable is negative in the kernelspace.
> 
> This fixes the creation of additional subflows where the remote port has
> to be reused if the other host didn't announce another one. This also
> fixes inet_diag showing blank info about MPTCP sockets from unblocking
> sockets doing a connect().
> 
> Fixes: 41be81a8d3d0 ("mptcp: fix unblocking connect()")
> Signed-off-by: Matthieu Baerts <matthieu.baerts@...sares.net>

Applied, thanks!