netdev - Re: [PATCH] net: mscc: ocelot: fix hardware timestamp dequeue logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200727.120608.2245293587733963820.davem@davemloft.net>
Date:   Mon, 27 Jul 2020 12:06:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yangbo.lu@....com
Cc:     netdev@...r.kernel.org, laurent.brando@....com,
        vladimir.oltean@....com, claudiu.manoil@....com,
        alexandre.belloni@...tlin.com, kuba@...nel.org,
        UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH] net: mscc: ocelot: fix hardware timestamp dequeue logic

From: Yangbo Lu <yangbo.lu@....com>
Date: Mon, 27 Jul 2020 18:26:14 +0800

> From: laurent brando <laurent.brando@....com>
> 
> The next hw timestamp should be snapshoot to the read registers
> only once the current timestamp has been read.
> If none of the pending skbs matches the current HW timestamp
> just gracefully flush the available timestamp by reading it.
> 
> Signed-off-by: laurent brando <laurent.brando@....com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> Signed-off-by: Yangbo Lu <yangbo.lu@....com>

Applied and queued up for -stable, thanks.

So you have to read the hwtimestamp, even if you won't use it for
any packets?