netdev - Re: [PATCH net] fix a braino in cmsghdr_from_user_compat_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200727.132558.1865871927633102126.davem@davemloft.net>
Date:   Mon, 27 Jul 2020 13:25:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     viro@...iv.linux.org.uk
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        nbowler@...conx.ca
Subject: Re: [PATCH net] fix a braino in cmsghdr_from_user_compat_to_kern()

From: Al Viro <viro@...iv.linux.org.uk>
Date: Mon, 27 Jul 2020 19:22:20 +0100

> 	commit 547ce4cfb34c ("switch cmsghdr_from_user_compat_to_kern() to
> copy_from_user()") missed one of the places where ucmlen should've been
> replaced with cmsg.cmsg_len, now that we are fetching the entire struct
> rather than doing it field-by-field.
> 
> 	As the result, compat sendmsg() with several different-sized cmsg
> attached started to fail with EINVAL.  Trivial to fix, fortunately.
> 
> Reported-by: Nick Bowler <nbowler@...conx.ca>
> Tested-by: Nick Bowler <nbowler@...conx.ca>
> Fixes: 547ce4cfb34c ("switch cmsghdr_from_user_compat_to_kern() to copy_from_user()")
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>

Applied, thanks Al.