netdev - Re: [PATCH v2 bpf 2/2] selftests/bpf: extend map-in-map selftest to detect memory leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPhsuW77nCit0TweeBgermO=bHKztXEtKmh+pB7avXKH0hpZaQ@mail.gmail.com>
Date:   Mon, 27 Jul 2020 16:22:41 -0700
From:   Song Liu <song@...nel.org>
To:     Andrii Nakryiko <andriin@...com>
Cc:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Kernel Team <kernel-team@...com>,
        Song Liu <songliubraving@...com>, stable@...r.kernel.org
Subject: Re: [PATCH v2 bpf 2/2] selftests/bpf: extend map-in-map selftest to
 detect memory leaks

On Mon, Jul 27, 2020 at 4:15 PM Andrii Nakryiko <andriin@...com> wrote:
>
> Add test validating that all inner maps are released properly after skeleton
> is destroyed. To ensure determinism, trigger kernel-side synchronize_rcu()
> before checking map existence by their IDs.
>
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Acked-by: Song Liu <songliubraving@...com>

With a couple nit below.

> ---
>  .../selftests/bpf/prog_tests/btf_map_in_map.c | 121 ++++++++++++++++--
>  1 file changed, 108 insertions(+), 13 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/btf_map_in_map.c b/tools/testing/selftests/bpf/prog_tests/btf_map_in_map.c
> index f7ee8fa377ad..c06b61235212 100644
> --- a/tools/testing/selftests/bpf/prog_tests/btf_map_in_map.c
> +++ b/tools/testing/selftests/bpf/prog_tests/btf_map_in_map.c
> @@ -5,10 +5,59 @@
>
>  #include "test_btf_map_in_map.skel.h"
>
> +static int duration;
> +
> +__u32 bpf_map_id(struct bpf_map *map)

Make the function static?

[...]

> +int kern_sync_rcu() {

static int kern_sync_rcu(void)
{

checkpatch.pl should complain here.

Thanks,
Song

[...]