netdev - Re: [PATCH] net: xfrm: xfrm_policy.c: remove some unnecessary cases in decode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Jul 2020 11:36:17 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     B K Karthik <bkkarthik@...u.pes.edu>
CC:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: xfrm: xfrm_policy.c: remove some unnecessary cases
 in decode_session6

On Sat, Jul 25, 2020 at 07:19:49PM +0530, B K Karthik wrote:
> remove some unnecessary cases in decode_session6
> 
> Signed-off-by: B K Karthik <bkkarthik@...u.pes.edu>
> ---
>  net/xfrm/xfrm_policy.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
> index 19c5e0fa3f44..e1c988a89382 100644
> --- a/net/xfrm/xfrm_policy.c
> +++ b/net/xfrm/xfrm_policy.c
> @@ -3449,10 +3449,6 @@ decode_session6(struct sk_buff *skb, struct flowi *fl, bool reverse)
>  			fl6->flowi6_proto = nexthdr;
>  			return;
>  #endif
> -		/* XXX Why are there these headers? */
> -		case IPPROTO_AH:
> -		case IPPROTO_ESP:
> -		case IPPROTO_COMP:
>  		default:
>  			fl6->fl6_ipsec_spi = 0;
>  			fl6->flowi6_proto = nexthdr;

IPv4 implements spi parsing for these protocols, IPv6
does not do it. Before you just remove something, you
should think about which is the correct behaviour and
then do it for both, IPv4 and IPv6.