netdev - Re: [PATCH net-next 0/2] udp_tunnel: convert mlx5 to the new udp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Jul 2020 07:57:46 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "kuba@...nel.org" <kuba@...nel.org>
CC:     "mkubecek@...e.cz" <mkubecek@...e.cz>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH net-next 0/2] udp_tunnel: convert mlx5 to the new
 udp_tunnel infrastructure

On Fri, 2020-07-24 at 19:51 -0700, Jakub Kicinski wrote:
> This set converts mlx5 to the new infrastructure.
> 
> We need a small amount of special handling as mlx5 expects IANA VXLAN
> port to always be programmed into the device. ethtool will show such
> ports in a separate, type-less, fake table, at the end:
> 
> Tunnel information for eth0:
>   UDP port table 0: 
>     Size: 7
>     Types: vxlan
>     No entries
>   UDP port table 1: 
>     Size: 1
>     Types: none (static entries)
>     Entries (1):
>         port 4789, vxlan
> 
> Saeed - this should apply on top of net-next, independently of
> the Intel patches, would you mind taking this in for testing
> and review? I'll post the netdevsim & test once Intel patches
> re-emerge.
> 

Hi Jakub, thanks for the patches.

We had some failures in our internal regression and it seems to be
related to these patches, something with vxlan test case with
representors and switchdev mode, we will be debugging and will let you
know.

> Jakub Kicinski (2):
>   udp_tunnel: add the ability to hard-code IANA VXLAN
>   mlx5: convert to new udp_tunnel infrastructure
> 
>  Documentation/networking/ethtool-netlink.rst  |  3 +
>  drivers/net/ethernet/mellanox/mlx5/core/en.h  |  2 -
>  .../net/ethernet/mellanox/mlx5/core/en_main.c | 88 ++---------------
> --
>  .../net/ethernet/mellanox/mlx5/core/en_rep.c  |  2 -
>  .../ethernet/mellanox/mlx5/core/lib/vxlan.c   | 87 +++++++++------
> ---
>  .../ethernet/mellanox/mlx5/core/lib/vxlan.h   |  6 +-
>  include/net/udp_tunnel.h                      |  5 ++
>  net/ethtool/tunnels.c                         | 69 +++++++++++++--
>  net/ipv4/udp_tunnel_nic.c                     |  7 ++
>  9 files changed, 126 insertions(+), 143 deletions(-)
>