netdev - Re: [PATCH bpf-next 0/2] tools: bpftool: update prog names list and fix segfault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9623ce12-6a3f-77ad-7fae-40bb93761efc@iogearbox.net>
Date:   Tue, 28 Jul 2020 12:16:07 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Quentin Monnet <quentin@...valent.com>,
        Alexei Starovoitov <ast@...nel.org>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org,
        Paul Chaignon <paul@...ium.io>
Subject: Re: [PATCH bpf-next 0/2] tools: bpftool: update prog names list and
 fix segfault

On 7/24/20 11:06 AM, Quentin Monnet wrote:
> Although probing features with bpftool works fine if bpftool's array of
> program and map type names lack the latest kernel additions, it can crash
> if there are some types missing _in the middle_ of the arrays. The case
> recently occurred with the addition of the "sk_lookup" name, which skipped
> the "lsm" in the list.
> 
> Let's update the list, and let's make sure it does not crash bpftool again
> if we omit other types again in the future.
> 
> Quentin Monnet (2):
>    tools: bpftool: skip type probe if name is not found
>    tools: bpftool: add LSM type to array of prog names
> 
>   tools/bpf/bpftool/feature.c | 8 ++++++++
>   tools/bpf/bpftool/prog.c    | 1 +
>   2 files changed, 9 insertions(+)
> 

Applied, thanks!