netdev - Re: [net 11/12] net/mlx5e: Modify uplink state on interface up/down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMg+wW2FFrC3rRQyQbcSJKFf5Lr9EvNYuRQ0JZEDAztw7g@mail.gmail.com>
Date:   Tue, 28 Jul 2020 13:24:07 +0300
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Ron Diskin <rondi@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Linux Netdev List <netdev@...r.kernel.org>,
        Moshe Shemesh <moshe@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Roi Dayan <roid@...lanox.com>
Subject: Re: [net 11/12] net/mlx5e: Modify uplink state on interface up/down

On Tue, Jul 28, 2020 at 12:16 PM Saeed Mahameed <saeedm@...lanox.com> wrote:
> From: Ron Diskin <rondi@...lanox.com>
>
> When setting the PF interface up/down, notify the firmware to update
> uplink state via MODIFY_VPORT_STATE

How this relates to e-switching? the patch touches the e-switch code
but I don't see mentioning of that in the change-log..

> This behavior will prevent sending traffic out on uplink port when PF is
> down, such as sending traffic from a VF interface which is still up.
> Currently when calling mlx5e_open/close(), the driver only sends PAOS
> command to notify the firmware to set the physical port state to
> up/down, however, it is not sufficient. When VF is in "auto" state, it

"auto" is nasty concept that applies only to legacy mode. However, the patch
touches the switchdev mode (representors) code, please explain...

> follows the uplink state, which was not updated on mlx5e_open/close()
> before this patch.
>
> Fixes: 63bfd399de55 ("net/mlx5e: Send PAOS command on interface up/down")
> Signed-off-by: Ron Diskin <rondi@...lanox.com>
> Reviewed-by: Roi Dayan <roid@...lanox.com>
> Reviewed-by: Moshe Shemesh <moshe@...lanox.com>