netdev - [vhost:vhost 40/45] drivers/virtio/virtio_vdpa.c:301:9: error: void value not ignored as it ought to be

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202007281956.HeB9nxyO%lkp@intel.com>
Date:   Tue, 28 Jul 2020 19:31:00 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
Cc:     kbuild-all@...ts.01.org, kvm@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org
Subject: [vhost:vhost 40/45] drivers/virtio/virtio_vdpa.c:301:9: error: void
 value not ignored as it ought to be

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head:   84d40e4b4bc64456abf5ef5663871053b40e84ac
commit: 03750f7fa49f9384911059fe16f5367b7e86f99d [40/45] virtio_vdpa: legacy features handling
config: nds32-randconfig-r003-20200728 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 03750f7fa49f9384911059fe16f5367b7e86f99d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

   In file included from drivers/virtio/virtio_vdpa.c:17:
   include/linux/vdpa.h:43:21: error: expected ':', ',', ';', '}' or '__attribute__' before '.' token
      43 |  bool features_valid.
         |                     ^
   include/linux/vdpa.h: In function 'vdpa_reset':
   include/linux/vdpa.h:276:6: error: 'struct vdpa_device' has no member named 'features_valid'
     276 |  vdev->features_valid = false;
         |      ^~
   include/linux/vdpa.h: In function 'vdpa_set_features':
   include/linux/vdpa.h:284:6: error: 'struct vdpa_device' has no member named 'features_valid'
     284 |  vdev->features_valid = true;
         |      ^~
   include/linux/vdpa.h: In function 'vdpa_get_config':
   include/linux/vdpa.h:298:11: error: 'struct vdpa_device' has no member named 'features_valid'
     298 |  if (!vdev->features_valid)
         |           ^~
   drivers/virtio/virtio_vdpa.c: In function 'virtio_vdpa_get':
   drivers/virtio/virtio_vdpa.c:60:32: warning: unused variable 'ops' [-Wunused-variable]
      60 |  const struct vdpa_config_ops *ops = vdpa->config;
         |                                ^~~
   drivers/virtio/virtio_vdpa.c: In function 'virtio_vdpa_finalize_features':
>> drivers/virtio/virtio_vdpa.c:301:9: error: void value not ignored as it ought to be
     301 |  return vdpa_set_features(vdpa, vdev->features);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/virtio/virtio_vdpa.c:296:32: warning: unused variable 'ops' [-Wunused-variable]
     296 |  const struct vdpa_config_ops *ops = vdpa->config;
         |                                ^~~
>> drivers/virtio/virtio_vdpa.c:302:1: warning: control reaches end of non-void function [-Wreturn-type]
     302 | }
         | ^

vim +301 drivers/virtio/virtio_vdpa.c

   292	
   293	static int virtio_vdpa_finalize_features(struct virtio_device *vdev)
   294	{
   295		struct vdpa_device *vdpa = vd_get_vdpa(vdev);
   296		const struct vdpa_config_ops *ops = vdpa->config;
   297	
   298		/* Give virtio_ring a chance to accept features. */
   299		vring_transport_features(vdev);
   300	
 > 301		return vdpa_set_features(vdpa, vdev->features);
 > 302	}
   303	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (20367 bytes)