netdev - Re: [net-next v4 3/6] net: marvell: prestera: Add basic devlink support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcdpwqpRqm99aHivTkEsxF6-4SENVz09oV=JJTjh8eyVA@mail.gmail.com>
Date:   Tue, 28 Jul 2020 16:24:42 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Vadym Kochan <vadym.kochan@...ision.eu>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>,
        Andrew Lunn <andrew@...n.ch>,
        Oleksandr Mazur <oleksandr.mazur@...ision.eu>,
        Serhiy Boiko <serhiy.boiko@...ision.eu>,
        Serhiy Pshyk <serhiy.pshyk@...ision.eu>,
        Volodymyr Mytnyk <volodymyr.mytnyk@...ision.eu>,
        Taras Chornyi <taras.chornyi@...ision.eu>,
        Andrii Savka <andrii.savka@...ision.eu>,
        netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mickey Rachamim <mickeyr@...vell.com>
Subject: Re: [net-next v4 3/6] net: marvell: prestera: Add basic devlink support

On Tue, Jul 28, 2020 at 3:30 PM Vadym Kochan <vadym.kochan@...ision.eu> wrote:
> On Mon, Jul 27, 2020 at 04:07:07PM +0300, Andy Shevchenko wrote:
> > On Mon, Jul 27, 2020 at 3:23 PM Vadym Kochan <vadym.kochan@...ision.eu> wrote:

...

> > > +       err = devlink_register(dl, sw->dev->dev);
> > > +       if (err) {
> > > +               dev_warn(sw->dev->dev, "devlink_register failed: %d\n", err);
> > > +               return err;
> > > +       }
> > > +
> > > +       return 0;
> >
> >   if (err)
> >     dev_warn(...);
> >
> >   return err;
> Would not it better to have 'return 0' at the end to visually indicate
> the success point ?

Up to you. Actually just noticed that you are using dev_warn() for
error. It should be dev_err().

-- 
With Best Regards,
Andy Shevchenko