netdev - Re: [PATCH net-next v2 1/2] mlxsw: core: Add ethtool support for QSFP-DD transceivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200728140453.GF1705504@lunn.ch>
Date:   Tue, 28 Jul 2020 16:04:53 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        jiri@...lanox.com, vadimp@...lanox.com, popadrian1996@...il.com,
        mlxsw@...lanox.com, Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next v2 1/2] mlxsw: core: Add ethtool support for
 QSFP-DD transceivers

On Tue, Jul 28, 2020 at 01:20:15PM +0300, Ido Schimmel wrote:
> From: Vadim Pasternak <vadimp@...lanox.com>
> 
> The Quad Small Form Factor Pluggable Double Density (QSFP-DD) hardware
> specification defines a form factor that supports up to 400 Gbps in
> aggregate over an 8x50-Gbps electrical interface. The QSFP-DD supports
> both optical and copper interfaces.
> 
> Implementation is based on Common Management Interface Specification;
> Rev 4.0 May 8, 2019. Table 8-2 "Identifier and Status Summary (Lower
> Page)" from this spec defines "Id and Status" fields located at offsets
> 00h - 02h. Bit 2 at offset 02h ("Flat_mem") specifies QSFP EEPROM memory
> mode, which could be "upper memory flat" or "paged". Flat memory mode is
> coded "1", and indicates that only page 00h is implemented in EEPROM.
> Paged memory is coded "0" and indicates that pages 00h, 01h, 02h, 10h
> and 11h are implemented. Pages 10h and 11h are currently not supported
> by the driver.
> 
> "Flat" memory mode is used for the passive copper transceivers. For this
> type only page 00h (256 bytes) is available. "Paged" memory is used for
> the optical transceivers. For this type pages 00h (256 bytes), 01h (128
> bytes) and 02h (128 bytes) are available. Upper page 01h contains static
> advertising field, while upper page 02h contains the module-defined
> thresholds and lane-specific monitors.
> 
> Extend enumerator 'mlxsw_reg_mcia_eeprom_module_info_id' with additional
> field 'MLXSW_REG_MCIA_EEPROM_MODULE_INFO_TYPE_ID'. This field is used to
> indicate for QSFP-DD transceiver type which memory mode is to be used.
> 
> Expose 256 bytes buffer for QSFP-DD passive copper transceiver and
> 512 bytes buffer for optical.
> 
> Signed-off-by: Vadim Pasternak <vadimp@...lanox.com>
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew