netdev - Re: [net 01/12] net/mlx5e: Hold reference on mirred devices while accessing them

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b82449d6fb17471cc23e84f59d264b6b05b08762.camel@mellanox.com>
Date:   Tue, 28 Jul 2020 19:32:05 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     Eli Cohen <eli@...lanox.com>,
        "gerlitz.or@...il.com" <gerlitz.or@...il.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        Vlad Buslov <vladbu@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [net 01/12] net/mlx5e: Hold reference on mirred devices while
 accessing them

On Tue, 2020-07-28 at 13:27 +0300, Or Gerlitz wrote:
> On Tue, Jul 28, 2020 at 12:13 PM Saeed Mahameed <saeedm@...lanox.com>
> wrote:
> > From: Eli Cohen <eli@...lanox.com>
> > 
> > Net devices might be removed. For example, a vxlan device could be
> > deleted and its ifnidex would become invalid. Use
> > dev_get_by_index()
> > instead of __dev_get_by_index() to hold reference on the device
> > while
> > accessing it and release after done.
> 
> haven't this patch sent in the past in the same form and we were in
> the middle
> of discussing how to properly address this? if something changed,
> what?

I thought the discussion was concluded ? 

anyway i will remove this patch from my trees, Eli please discuss with
Or, i am fine with this patch as is since it is a minimal fix to net.