netdev - RE: [PATCH net-next 0/2] dpaa2-eth: add reset control for debugfs stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB3871A275CC602BFCBBCDA63BE0730@VI1PR0402MB3871.eurprd04.prod.outlook.com>
Date:   Tue, 28 Jul 2020 20:03:15 +0000
From:   Ioana Ciornei <ioana.ciornei@....com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 0/2] dpaa2-eth: add reset control for debugfs
 stats

> Subject: Re: [PATCH net-next 0/2] dpaa2-eth: add reset control for debugfs stats
> 
> On Tue, 28 Jul 2020 19:33:46 +0000 Ioana Ciornei wrote:
> > > Subject: Re: [PATCH net-next 0/2] dpaa2-eth: add reset control for
> > > debugfs stats No, come on, you know what we're going to say to a debugfs
> patch like this...
> >
> > Eh, I figured it was worth a try since I saw that i40e also supports
> > clearing the stats through debugfs.
> 
> The stuff that got snuck into i40e is the reason I pay very close attention to Intel
> patches these days.
> 
> > > Is there anything dpaa2-specific here?  We should be able to add a
> > > common API for this.
> >
> > No, there is nothing dpaa2-specific. The common API would be in the
> > 'ethtool --reset' area or do you have anything other in mind?
> 
> We have this huge ongoing discussion about devlink reset/reload:
> 
> https://lore.kernel.org/netdev/1595847753-2234-1-git-send-email-moshe@mellanox.com/
> 
> Perhaps it could fit in there? I presume your reset is on the device level? If it's
> per netdev, I'd personally not be opposed to extending the ethtool API.

The reset available is per netdev, that is why I was thinking about ethtool rather than devlink.

Ioana