netdev - Re: [PATCH bpf-next] bpf: fix build without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW63iuBcMiw0TKRSBH68F7GRC9o4JUC6JLx0ij4WK6KX7w@mail.gmail.com>
Date:   Tue, 28 Jul 2020 13:23:51 -0700
From:   Song Liu <song@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next] bpf: fix build without CONFIG_NET when using BPF
 XDP link

On Tue, Jul 28, 2020 at 1:08 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> On 7/28/20 12:05 PM, Andrii Nakryiko wrote:
> > Entire net/core subsystem is not built without CONFIG_NET. linux/netdevice.h
> > just assumes that it's always there, so the easiest way to fix this is to
> > conditionally compile out bpf_xdp_link_attach() use in bpf/syscall.c.
> >
> > Reported-by: Randy Dunlap <rdunlap@...radead.org>
> > Fixes: aa8d3a716b59 ("bpf, xdp: Add bpf_link-based XDP attachment API")
> > Signed-off-by: Andrii Nakryiko <andriin@...com>
>
> Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Acked-by: Song Liu <songliubraving@...com>