netdev - Re: [PATCH net-next v2] net: mvneta: fix comment about phylink_speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200729100940.GY1551@shell.armlinux.org.uk>
Date:   Wed, 29 Jul 2020 11:09:40 +0100
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Jisheng Zhang <Jisheng.Zhang@...aptics.com>
Cc:     Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: mvneta: fix comment about
 phylink_speed_down

On Wed, Jul 29, 2020 at 05:49:09PM +0800, Jisheng Zhang wrote:
> mvneta has switched to phylink, so the comment should look
> like "We may have called phylink_speed_down before".
> 
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@...aptics.com>

Reviewed-by: Russell King <rmk+kernel@...linux.org.uk>

> ---
> Since v1:
>   - drop patch2 which tries to avoid link flapping when changing mtu
>     I need more time on the change mtu refactoring.
> 
>  drivers/net/ethernet/marvell/mvneta.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> index 2c9277e73cef..c9b6b0f85bb0 100644
> --- a/drivers/net/ethernet/marvell/mvneta.c
> +++ b/drivers/net/ethernet/marvell/mvneta.c
> @@ -3637,7 +3637,7 @@ static void mvneta_start_dev(struct mvneta_port *pp)
>  
>  	phylink_start(pp->phylink);
>  
> -	/* We may have called phy_speed_down before */
> +	/* We may have called phylink_speed_down before */
>  	phylink_speed_up(pp->phylink);
>  
>  	netif_tx_start_all_queues(pp->dev);
> -- 
> 2.28.0.rc0
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!