netdev - Re: [PATCH net] vxlan: Ensure FDB dump is performed under RCU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200729.121104.4622726933132816.davem@davemloft.net>
Date:   Wed, 29 Jul 2020 12:11:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, kuba@...nel.org, jhs@...atatu.com,
        jiri@...lanox.com, mlxsw@...lanox.com, idosch@...lanox.com
Subject: Re: [PATCH net] vxlan: Ensure FDB dump is performed under RCU

From: Ido Schimmel <idosch@...sch.org>
Date: Wed, 29 Jul 2020 11:34:36 +0300

> From: Ido Schimmel <idosch@...lanox.com>
> 
> The commit cited below removed the RCU read-side critical section from
> rtnl_fdb_dump() which means that the ndo_fdb_dump() callback is invoked
> without RCU protection.
> 
> This results in the following warning [1] in the VXLAN driver, which
> relied on the callback being invoked from an RCU read-side critical
> section.
> 
> Fix this by calling rcu_read_lock() in the VXLAN driver, as already done
> in the bridge driver.
> 
> [1]
> WARNING: suspicious RCU usage
> 5.8.0-rc4-custom-01521-g481007553ce6 #29 Not tainted
 ...
> Fixes: 5e6d24358799 ("bridge: netlink dump interface at par with brctl")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>

Applied and queued up for -stable, thanks.