netdev - Re: [PATCH] uapi, seg6_iptunnel: Add missing include in seg6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200729.125010.1457267567599420810.davem@davemloft.net>
Date:   Wed, 29 Jul 2020 12:50:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ioanaruxandra.stancioi@...il.com
Cc:     david.lebrun@...ouvain.be, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, elver@...gle.com, glider@...gle.com,
        stancioi@...gle.com
Subject: Re: [PATCH] uapi, seg6_iptunnel: Add missing include in
 seg6_iptunnel.h

From: Ioana-Ruxandra Stancioi <ioanaruxandra.stancioi@...il.com>
Date: Wed, 29 Jul 2020 10:49:03 +0000

> From: Ioana-Ruxandra Stăncioi <stancioi@...gle.com>
> 
> Include <linux/ipv6.h> in uapi/linux/seg6_iptunnel.h to fix the
> following linux/seg6_iptunnel.h compilation error:
> 
>    invalid application of 'sizeof' to incomplete type 'struct ipv6hdr'
>        head = sizeof(struct ipv6hdr);
>                      ^~~~~~
> 
> This is to allow including this header in places where <linux/ipv6.h>
> has not been included but __KERNEL__ is defined. In the kernel the easy
> workaround is including <linux/ipv6.h>, but the header may also be used
> by code analysis tools.
> 
> Signed-off-by: Ioana-Ruxandra Stăncioi <stancioi@...gle.com>

This doesn't belong in a UAPI header (it's __KERNEL__ protected after
all), and it's only called in one place in the kernel, namely
net/ipv6/net/ipv6/seg6_iptunnel.c)

Just move the helper to that foo.c file, and drop the inline keyword.

Thank you.