netdev - Re: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200729134915.5896edc3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 29 Jul 2020 13:49:15 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     David Thompson <dthompson@...lanox.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jiri@...lanox.com,
        Asmaa Mnebhi <asmaa@...lanox.com>
Subject: Re: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

On Wed, 29 Jul 2020 14:29:15 -0400 David Thompson wrote:
> This patch adds build and driver logic for the "mlxbf_gige"
> Ethernet driver from Mellanox Technologies.

Please fix these W=1 C=1 warnings:

drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:256:29: warning: Using plain integer as NULL pointer
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:258:29: warning: Using plain integer as NULL pointer
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:292:29: warning: Using plain integer as NULL pointer
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:294:23: warning: Using plain integer as NULL pointer
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:296:29: warning: Using plain integer as NULL pointer
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:329:25: warning: incorrect type in assignment (different base types)
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:329:25:    expected unsigned long long [usertype]
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:329:25:    got restricted __be64 [usertype]
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c: In function ‘mlxbf_gige_initial_mac’:
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:1093:6: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]
 1093 |  int status;
      |      ^~~~~~