netdev - Re: [PATCH v2 0/9] ptp: Add generic header parsing function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Jul 2020 17:47:18 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kurt@...utronix.de
Cc:     richardcochran@...il.com, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, kuba@...nel.org, jiri@...lanox.com,
        idosch@...lanox.com, hkallweit1@...il.com, linux@...linux.org.uk,
        grygorii.strashko@...com, ivan.khoronzhuk@...aro.org,
        zou_wei@...wei.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 0/9] ptp: Add generic header parsing function

From: Kurt Kanzenbach <kurt@...utronix.de>
Date: Mon, 27 Jul 2020 11:05:52 +0200

> in order to reduce code duplication in the ptp code of DSA, Ethernet and Phy
> drivers, move the header parsing function to ptp_classify. This way all drivers
> can share the same implementation. Implemented as discussed [1] [2] [3].
> 
> This is version two and contains more driver conversions.
> 
> Richard, can you test with your hardware? I'll do the same e.g. on the bbb.
> 
> Version 1 can be found here:
> 
>  * https://lkml.kernel.org/netdev/20200723074946.14253-1-kurt@linutronix.de/

It looks like some mlxsw et al. issues wrt. which header is expected at
skb->data when certain helper functions are invoked need to be resolved
still.