netdev - Re: [net V2 10/11] net/mlx5e: Modify uplink state on interface up/down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 29 Jul 2020 06:38:08 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "gerlitz.or@...il.com" <gerlitz.or@...il.com>
CC:     Moshe Shemesh <moshe@...lanox.com>, Roi Dayan <roid@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        Ron Diskin <rondi@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [net V2 10/11] net/mlx5e: Modify uplink state on interface
 up/down

On Wed, 2020-07-29 at 09:17 +0300, Or Gerlitz wrote:
> On Tue, Jul 28, 2020 at 11:07 PM Saeed Mahameed <saeedm@...lanox.com>
> wrote:
> > When setting the PF interface up/down, notify the firmware to
> > update
> > uplink state via MODIFY_VPORT_STATE, when E-Switch is enabled.
> > This behavior will prevent sending traffic out on uplink port when
> > PF is
> > down, such as sending traffic from a VF interface which is still
> > up.
> > Currently when calling mlx5e_open/close(), the driver only sends
> > PAOS
> > command to notify the firmware to set the physical port state to
> > up/down, however, it is not sufficient. When VF is in "auto" state,
> > it
> > follows the uplink state, which was not updated on
> > mlx5e_open/close()
> > before this patch.
> > When switchdev mode is enabled and uplink representor is first
> > enabled,
> > set the uplink port state value back to its FW default "AUTO".
> 
> So this is not the legacy mode "auto" vf vport state but rather
> something else?
> 

Or, this is the uplink esw port and not the PF's, auto means 
FW/HW manages the state according to the actual physical link state.

> If this is the case what is the semantics of the firmware "auto"
> state and
> how it related to the switchdev vport representors
> architecture/behaviour?
> 

No change in the current switchdev behavior, only for legacy and NONE
mode. 

> 
> > Fixes: 63bfd399de55 ("net/mlx5e: Send PAOS command on interface
> > up/down")