netdev - Re: [PATCH] net: nixge: fix potential memory leak in nixge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <81c16524-29f0-4331-5843-9b2e2c0ee22e@web.de>
Date:   Wed, 29 Jul 2020 09:49:51 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Lu Wei <luwei32@...wei.com>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Alex Williams <alex.williams@...com>,
        Andrew Lunn <andrew@...n.ch>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Moritz Fischer <mdf@...nel.org>,
        Yunjian Wang <wangyunjian@...wei.com>
Subject: Re: [PATCH] net: nixge: fix potential memory leak in nixge_probe()

> If some processes in nixge_probe() fail, free_netdev(dev)
> needs to be called to aviod a memory leak.

* Would you like to avoid a typo in this change description?

* An imperative wording can be preferred here, can't it?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=6ba1b005ffc388c2aeaddae20da29e4810dea298#n151

Regards,
Markus