netdev - Re: [PATCH net-next 05/10] tcp: pass want_cookie down to req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200730175843.GD5271@breakpoint.cc>
Date:   Thu, 30 Jul 2020 19:58:43 +0200
From:   Florian Westphal <fw@...len.de>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     Florian Westphal <fw@...len.de>, netdev <netdev@...r.kernel.org>,
        mathew.j.martineau@...ux.intel.com,
        Matthieu Baerts <matthieu.baerts@...sares.net>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 05/10] tcp: pass want_cookie down to req_init
 function

Eric Dumazet <edumazet@...gle.com> wrote:
> On Thu, Jul 30, 2020 at 10:15 AM Florian Westphal <fw@...len.de> wrote:
> >
> > In MPTCP case, we want to know if we should store a new token id or if we
> > should try best-effort only (cookie case).
> >
> > This allows the MPTCP core to detect when it should elide the storage
> > of the generated MPTCP token.
> >
> 
> It seems you add later another patch, introducing cookie_tcp_reqsk_alloc()
> 
> We could rename req->cookie_ts  bit to req->syncookie  in order to not
> change function signatures.

Ok, I will update patch #1 to do a rename instead of removing cookie_ts
bit.  I will keep the change in output path to check synack_type instead
of cookie_ts.