netdev - RE: [PATCH net-next] liquidio: Replace vmalloc with kmalloc in octeon_register_dispatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <BYAPR18MB2423C7A710232C87229FF90BAC710@BYAPR18MB2423.namprd18.prod.outlook.com>
Date:   Thu, 30 Jul 2020 18:58:57 +0000
From:   Derek Chickles <dchickles@...vell.com>
To:     Wang Hai <wanghai38@...wei.com>,
        "joe@...ches.com" <joe@...ches.com>,
        Satananda Burla <sburla@...vell.com>,
        Felix Manlunas <fmanlunas@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next] liquidio: Replace vmalloc with kmalloc in
 octeon_register_dispatch_fn()

> From: Wang Hai <wanghai38@...wei.com>
> Sent: Wednesday, July 29, 2020 11:12 PM
> To: joe@...ches.com; Derek Chickles <dchickles@...vell.com>; Satananda
> Burla <sburla@...vell.com>; Felix Manlunas <fmanlunas@...vell.com>;
> davem@...emloft.net; kuba@...nel.org
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [EXT] [PATCH net-next] liquidio: Replace vmalloc with kmalloc in
> octeon_register_dispatch_fn()
> 
> The size of struct octeon_dispatch is too small, it is better to use kmalloc
> instead of vmalloc.
> 
> Suggested-by: Joe Perches <joe@...ches.com>
> Signed-off-by: Wang Hai <wanghai38@...wei.com>
> ---
>  drivers/net/ethernet/cavium/liquidio/octeon_device.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c
> b/drivers/net/ethernet/cavium/liquidio/octeon_device.c
> index 934115d18488..ac32facaa427 100644
> --- a/drivers/net/ethernet/cavium/liquidio/octeon_device.c
> +++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.c
> @@ -1056,7 +1056,7 @@ void octeon_delete_dispatch_list(struct
> octeon_device *oct)
> 
>  	list_for_each_safe(temp, tmp2, &freelist) {
>  		list_del(temp);
> -		vfree(temp);
> +		kfree(temp);
>  	}
>  }
> 
> @@ -1152,13 +1152,10 @@ octeon_register_dispatch_fn(struct
> octeon_device *oct,
> 
>  		dev_dbg(&oct->pci_dev->dev,
>  			"Adding opcode to dispatch list linked list\n");
> -		dispatch = (struct octeon_dispatch *)
> -			   vmalloc(sizeof(struct octeon_dispatch));
> -		if (!dispatch) {
> -			dev_err(&oct->pci_dev->dev,
> -				"No memory to add dispatch function\n");
> +		dispatch = kmalloc(sizeof(*dispatch), GFP_KERNEL);
> +		if (!dispatch)
>  			return 1;
> -		}
> +
>  		dispatch->opcode = combined_opcode;
>  		dispatch->dispatch_fn = fn;
>  		dispatch->arg = fn_arg;
> --
> 2.17.1

Looks good.

Reviewed-by: Derek Chickles <dchickles@...vell.com>