netdev - Re: [PATCH bpf-next] selftests/bpf: Omit nodad flag when adding addresses to loopback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4Bzan-B5ZTc6jSf3Dut7frEKq1XhYxg3sTtdKbds+mmmrrQ@mail.gmail.com>
Date:   Thu, 30 Jul 2020 12:30:53 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Jakub Sitnicki <jakub@...udflare.com>
Cc:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        kernel-team <kernel-team@...udflare.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH bpf-next] selftests/bpf: Omit nodad flag when adding
 addresses to loopback

On Thu, Jul 30, 2020 at 5:53 AM Jakub Sitnicki <jakub@...udflare.com> wrote:
>
> Setting IFA_F_NODAD flag for IPv6 addresses to add to loopback is
> unnecessary. Duplicate Address Detection does not happen on loopback
> device.
>
> Also, passing 'nodad' flag to 'ip address' breaks libbpf CI, which runs in
> an environment with BusyBox implementation of 'ip' command, that doesn't
> understand this flag.
>
> Fixes: 0ab5539f8584 ("selftests/bpf: Tests for BPF_SK_LOOKUP attach point")
> Reported-by: Andrii Nakryiko <andrii.nakryiko@...il.com>
> Signed-off-by: Jakub Sitnicki <jakub@...udflare.com>
> ---


This fixes the nodad issue, thanks for quick fix!

Tested-by: Andrii Nakryiko <andrii@...com>
Acked-by: Andrii Nakryiko <andriin@...com>


But now I see these, which seems like you have a separate fix for, right?

(network_helpers.c:112: errno: Cannot assign requested address) Failed
to connect to server
run_lookup_test:FAIL:connect_fd_to_fd unexpected result err -1 errno 99
#14 cgroup_skb_sk_lookup:FAIL

udp_recv_send:FAIL:recvmsg failed
(/data/users/andriin/linux/tools/testing/selftests/bpf/prog_tests/sk_lookup.c:339:
errno: Resource temporarily unavailable) failed to receive
#73/14 UDP IPv4 redir and reuseport with conns:FAIL


>  tools/testing/selftests/bpf/prog_tests/sk_lookup.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/sk_lookup.c b/tools/testing/selftests/bpf/prog_tests/sk_lookup.c
> index 9bbd2b2b7630..379da6f10ee9 100644
> --- a/tools/testing/selftests/bpf/prog_tests/sk_lookup.c
> +++ b/tools/testing/selftests/bpf/prog_tests/sk_lookup.c
> @@ -1290,8 +1290,8 @@ static void run_tests(struct test_sk_lookup *skel)
>  static int switch_netns(void)
>  {
>         static const char * const setup_script[] = {
> -               "ip -6 addr add dev lo " EXT_IP6 "/128 nodad",
> -               "ip -6 addr add dev lo " INT_IP6 "/128 nodad",
> +               "ip -6 addr add dev lo " EXT_IP6 "/128",
> +               "ip -6 addr add dev lo " INT_IP6 "/128",
>                 "ip link set dev lo up",
>                 NULL,
>         };
> --
> 2.25.4
>