netdev - Re: [PATCH net-next 08/12] sfc_ef100: statistics gathering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 31 Jul 2020 03:25:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Edward Cree <ecree@...arflare.com>,
        linux-net-drivers@...arflare.com, davem@...emloft.net
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 08/12] sfc_ef100: statistics gathering

Hi Edward,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Edward-Cree/sfc-driver-for-EF100-family-NICs-part-2/20200730-224221
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 41d707b7332f1386642c47eb078110ca368a46f5
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/sfc/ef100_nic.c: In function 'ef100_get_stat_mask':
>> drivers/net/ethernet/sfc/ef100_nic.c:456:32: warning: conversion from 'long long unsigned int' to 'long unsigned int' changes value from '274877906943' to '4294967295' [-Woverflow]
     456 | #define EF100_COMMON_STAT_MASK ((1ULL << EF100_STAT_port_tx_bytes) |  \
         |                                ^
   drivers/net/ethernet/sfc/ef100_nic.c:542:10: note: in expansion of macro 'EF100_COMMON_STAT_MASK'
     542 |  *mask = EF100_COMMON_STAT_MASK;
         |          ^~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/sfc/ef100_nic.c: At top level:
   drivers/net/ethernet/sfc/ef100_nic.c:706:3: error: 'const struct efx_nic_type' has no member named 'filter_rfs_expire_one'
     706 |  .filter_rfs_expire_one = efx_mcdi_filter_rfs_expire_one,
         |   ^~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/sfc/ef100_nic.c:706:27: error: initialization of 'int (*)(struct efx_nic *)' from incompatible pointer type 'bool (*)(struct efx_nic *, u32,  unsigned int)' {aka '_Bool (*)(struct efx_nic *, unsigned int,  unsigned int)'} [-Werror=incompatible-pointer-types]
     706 |  .filter_rfs_expire_one = efx_mcdi_filter_rfs_expire_one,
         |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/sfc/ef100_nic.c:706:27: note: (near initialization for 'ef100_pf_nic_type.mtd_probe')
   cc1: some warnings being treated as errors

vim +456 drivers/net/ethernet/sfc/ef100_nic.c

   455	
 > 456	#define EF100_COMMON_STAT_MASK ((1ULL << EF100_STAT_port_tx_bytes) |		\
   457					(1ULL << EF100_STAT_port_tx_packets) |		\
   458					(1ULL << EF100_STAT_port_tx_pause) |		\
   459					(1ULL << EF100_STAT_port_tx_unicast) |		\
   460					(1ULL << EF100_STAT_port_tx_multicast) |	\
   461					(1ULL << EF100_STAT_port_tx_broadcast) |	\
   462					(1ULL << EF100_STAT_port_tx_lt64) |		\
   463					(1ULL << EF100_STAT_port_tx_64) |		\
   464					(1ULL << EF100_STAT_port_tx_65_to_127) |	\
   465					(1ULL << EF100_STAT_port_tx_128_to_255) |	\
   466					(1ULL << EF100_STAT_port_tx_256_to_511) |	\
   467					(1ULL << EF100_STAT_port_tx_512_to_1023) |	\
   468					(1ULL << EF100_STAT_port_tx_1024_to_15xx) |	\
   469					(1ULL << EF100_STAT_port_tx_15xx_to_jumbo) |	\
   470					(1ULL << EF100_STAT_port_rx_bytes) |		\
   471					(1ULL << EF100_STAT_port_rx_packets) |		\
   472					(1ULL << EF100_STAT_port_rx_good) |		\
   473					(1ULL << EF100_STAT_port_rx_bad) |		\
   474					(1ULL << EF100_STAT_port_rx_pause) |		\
   475					(1ULL << EF100_STAT_port_rx_unicast) |		\
   476					(1ULL << EF100_STAT_port_rx_multicast) |	\
   477					(1ULL << EF100_STAT_port_rx_broadcast) |	\
   478					(1ULL << EF100_STAT_port_rx_lt64) |		\
   479					(1ULL << EF100_STAT_port_rx_64) |		\
   480					(1ULL << EF100_STAT_port_rx_65_to_127) |	\
   481					(1ULL << EF100_STAT_port_rx_128_to_255) |	\
   482					(1ULL << EF100_STAT_port_rx_256_to_511) |	\
   483					(1ULL << EF100_STAT_port_rx_512_to_1023) |	\
   484					(1ULL << EF100_STAT_port_rx_1024_to_15xx) |	\
   485					(1ULL << EF100_STAT_port_rx_15xx_to_jumbo) |	\
   486					(1ULL << EF100_STAT_port_rx_gtjumbo) |		\
   487					(1ULL << EF100_STAT_port_rx_bad_gtjumbo) |	\
   488					(1ULL << EF100_STAT_port_rx_align_error) |	\
   489					(1ULL << EF100_STAT_port_rx_length_error) |	\
   490					(1ULL << EF100_STAT_port_rx_overflow) |		\
   491					(1ULL << EF100_STAT_port_rx_nodesc_drops) |	\
   492					(1ULL << GENERIC_STAT_rx_nodesc_trunc) |	\
   493					(1ULL << GENERIC_STAT_rx_noskb_drops))
   494	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (64446 bytes)