netdev - Re: [PATCH v2 net-next] mscc: Add LCPLL Reset to VSC8574 Family of phy drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94cacb22-c31d-4cd3-3872-2e431bafb0da@gmail.com>
Date:   Thu, 30 Jul 2020 16:40:15 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     David Miller <davem@...emloft.net>, Bryan.Whitehead@...rochip.com
Cc:     netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com,
        andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk
Subject: Re: [PATCH v2 net-next] mscc: Add LCPLL Reset to VSC8574 Family of
 phy drivers

On 7/30/20 4:36 PM, David Miller wrote:
> From: Bryan Whitehead <Bryan.Whitehead@...rochip.com>
> Date: Mon, 27 Jul 2020 13:18:28 -0400
> 
>> @@ -929,6 +929,77 @@ static bool vsc8574_is_serdes_init(struct phy_device *phydev)
>>  }
>>  
>>  /* bus->mdio_lock should be locked when using this function */
>> +/* Page should already be set to MSCC_PHY_PAGE_EXTENDED_GPIO */
>> +static int vsc8574_micro_command(struct phy_device *phydev, u16 command)
>  ...
>> +/* bus->mdio_lock should be locked when using this function */
> 
> Please don't dup this comment, it's not appropriate.

Agree put a mutex assertion instead if you want to catch offenders at
run time?
-- 
Florian