netdev - Re: [PATCH net] devlink: ignore -EOPNOTSUPP errors on dumpit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200730.165245.498996927458633882.davem@davemloft.net>
Date:   Thu, 30 Jul 2020 16:52:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kuba@...nel.org
Cc:     netdev@...r.kernel.org, andrew@...n.ch, jiri@...lanox.com,
        kernel-team@...com
Subject: Re: [PATCH net] devlink: ignore -EOPNOTSUPP errors on dumpit

From: Jakub Kicinski <kuba@...nel.org>
Date: Tue, 28 Jul 2020 16:15:07 -0700

> Number of .dumpit functions try to ignore -EOPNOTSUPP errors.
> Recent change missed that, and started reporting all errors
> but -EMSGSIZE back from dumps. This leads to situation like
> this:
> 
> $ devlink dev info
> devlink answers: Operation not supported
> 
> Dump should not report an error just because the last device
> to be queried could not provide an answer.
> 
> To fix this and avoid similar confusion make sure we clear
> err properly, and not leave it set to an error if we don't
> terminate the iteration.
> 
> Fixes: c62c2cfb801b ("net: devlink: don't ignore errors during dumpit")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Applied and queued up for -stable, thanks.