lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Jul 2020 16:25:12 +0200 From: "Rafael J. Wysocki" <rafael@...nel.org> To: Boris Ostrovsky <boris.ostrovsky@...cle.com> Cc: Anchal Agarwal <anchalag@...zon.com>, Stefano Stabellini <sstabellini@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>, "the arch/x86 maintainers" <x86@...nel.org>, Juergen Gross <jgross@...e.com>, Linux PM <linux-pm@...r.kernel.org>, Linux Memory Management List <linux-mm@...ck.org>, "Kamata, Munehisa" <kamatam@...zon.com>, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>, roger.pau@...rix.com, Jens Axboe <axboe@...nel.dk>, David Miller <davem@...emloft.net>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>, Peter Zijlstra <peterz@...radead.org>, Eduardo Valentin <eduval@...zon.com>, "Singh, Balbir" <sblbir@...zon.com>, xen-devel@...ts.xenproject.org, Vitaly Kuznetsov <vkuznets@...hat.com>, netdev <netdev@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, David Woodhouse <dwmw@...zon.co.uk>, Benjamin Herrenschmidt <benh@...nel.crashing.org> Subject: Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode On Fri, Jul 31, 2020 at 4:14 PM Boris Ostrovsky <boris.ostrovsky@...cle.com> wrote: > > On 7/30/20 7:06 PM, Anchal Agarwal wrote: > > On Mon, Jul 27, 2020 at 06:08:29PM -0400, Boris Ostrovsky wrote: > >> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > >> > >> > >> > >> On 7/24/20 7:01 PM, Stefano Stabellini wrote: > >>> Yes, it does, thank you. I'd rather not introduce unknown regressions so > >>> I would recommend to add an arch-specific check on registering > >>> freeze/thaw/restore handlers. Maybe something like the following: > >>> > >>> #ifdef CONFIG_X86 > >>> .freeze = blkfront_freeze, > >>> .thaw = blkfront_restore, > >>> .restore = blkfront_restore > >>> #endif > >>> > >>> > >>> maybe Boris has a better suggestion on how to do it > >> > >> An alternative might be to still install pm notifier in > >> drivers/xen/manage.c (I think as result of latest discussions we decided > >> we won't need it) and return -ENOTSUPP for ARM for > >> PM_HIBERNATION_PREPARE and friends. Would that work? > >> > > I think the question here is for registering driver specific freeze/thaw/restore > > callbacks for x86 only. I have dropped the pm_notifier in the v3 still pending > > testing. So I think just registering driver specific callbacks for x86 only is a > > good option. What do you think? > > > I suggested using the notifier under assumption that if it returns an > error then that will prevent callbacks to be called because hibernation > will be effectively disabled. That's correct.
Powered by blists - more mailing lists