netdev - Re: [PATCH v2 net-next 08/11] sfc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200731132732.2ddf3db6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 31 Jul 2020 13:27:32 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Edward Cree <ecree@...arflare.com>
Cc:     <linux-net-drivers@...arflare.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net-next 08/11] sfc_ef100: statistics gathering

On Fri, 31 Jul 2020 14:00:24 +0100 Edward Cree wrote:
> +	core_stats->rx_packets = stats[EF100_STAT_port_rx_packets];
> +	core_stats->tx_packets = stats[EF100_STAT_port_tx_packets];
> +	core_stats->rx_bytes = stats[EF100_STAT_port_rx_bytes];
> +	core_stats->tx_bytes = stats[EF100_STAT_port_tx_bytes];

> +	core_stats->multicast = stats[EF100_STAT_port_rx_multicast];

> +	core_stats->rx_crc_errors = stats[EF100_STAT_port_rx_bad];
> +	core_stats->rx_frame_errors =
> +			stats[EF100_STAT_port_rx_align_error];
> +	core_stats->rx_fifo_errors = stats[EF100_STAT_port_rx_overflow];

Since this is a new driver please stop reporting this in ethtool.
They clearly have a perfect match with the standard stats there is 
no need for duplication.