netdev - Re: [net-next 0/4] devlink flash update overwrite mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b148961d-317e-b995-5caa-a1cae44789c0@intel.com>
Date:   Fri, 31 Jul 2020 13:35:41 -0700
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, Jiri Pirko <jiri@...lanox.com>,
        Jonathan Corbet <corbet@....net>,
        Michael Chan <michael.chan@...adcom.com>,
        Bin Luo <luobin9@...wei.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Leon Romanovsky <leon@...nel.org>,
        Ido Schimmel <idosch@...lanox.com>,
        Danielle Ratson <danieller@...lanox.com>
Subject: Re: [net-next 0/4] devlink flash update overwrite mask



On 7/30/2020 5:39 PM, Jakub Kicinski wrote:
> LGTM,
> 
> minor suggestions:
>  - could you add opt-in support flags to struct devlink_ops, a'la
>    ethtool_ops->supported_coalesce_params so that you don't have to
>    modify all drivers to reject unsupported things?

Sure that makes sense.

>  - could you split patch 2 into an ice change and a devlink core
>    change?
> 

Yep.