netdev - Re: [PATCH net-next] mptcp: fix syncookie build error on UP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200801.115314.504388544316990261.davem@davemloft.net>
Date:   Sat, 01 Aug 2020 11:53:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fw@...len.de
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] mptcp: fix syncookie build error on UP

From: Florian Westphal <fw@...len.de>
Date: Sat,  1 Aug 2020 16:39:59 +0200

> kernel test robot says:
> net/mptcp/syncookies.c: In function 'mptcp_join_cookie_init':
> include/linux/kernel.h:47:38: warning: division by zero [-Wdiv-by-zero]
>  #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
> 
> I forgot that spinock_t size is 0 on UP, so ARRAY_SIZE cannot be used.
> 
> Fixes: 9466a1ccebbe54 ("mptcp: enable JOIN requests even if cookies are in use")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied, thanks.