lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 2 Aug 2020 13:22:37 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Kurt Kanzenbach <kurt@...utronix.de>, Richard Cochran <richardcochran@...il.com> Cc: Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Jiri Pirko <jiri@...lanox.com>, Ido Schimmel <idosch@...lanox.com>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, Grygorii Strashko <grygorii.strashko@...com>, Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>, Samuel Zou <zou_wei@...wei.com>, netdev@...r.kernel.org, Petr Machata <petrm@...lanox.com> Subject: Re: [PATCH v3 6/9] ethernet: ti: cpts: Use generic helper function On 7/30/2020 1:00 AM, Kurt Kanzenbach wrote: > In order to reduce code duplication between ptp drivers, generic helper > functions were introduced. Use them. > > Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de> > --- [snip] > - if (unlikely(ptp_class & PTP_CLASS_V1)) > - msgtype = data + offset + OFF_PTP_CONTROL; > - else > - msgtype = data + offset; > + msgtype = ptp_get_msgtype(hdr, ptp_class); > + seqid = be16_to_cpu(hdr->sequence_id); Same comment as patch 5 would probably apply here as well, with using ntohs(): Reviewed-by: Florian Fainelli <f.fainelli@...il.com> -- Florian
Powered by blists - more mailing lists