netdev - [PATCH] appletalk: Fix atalk_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 2 Aug 2020 07:06:51 +0200
From:   Lukas Wunner <lukas@...ner.de>
To:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     Vincent Duvert <vincent.ldev@...ert.net>,
        Christopher KOBAYASHI <chris@...avowed.jp>,
        Doug Brown <doug@...ntowndougbrown.com>,
        Yue Haibing <yuehaibing@...wei.com>, netdev@...r.kernel.org
Subject: [PATCH] appletalk: Fix atalk_proc_init() return path

From: Vincent Duvert <vincent.ldev@...ert.net>

Add a missing return statement to atalk_proc_init so it doesn't return
-ENOMEM when successful.  This allows the appletalk module to load
properly.

Fixes: e2bcd8b0ce6e ("appletalk: use remove_proc_subtree to simplify procfs code")
Link: https://www.downtowndougbrown.com/2020/08/hacking-up-a-fix-for-the-broken-appletalk-kernel-module-in-linux-5-1-and-newer/
Reported-by: Christopher KOBAYASHI <chris@...avowed.jp>
Reported-by: Doug Brown <doug@...ntowndougbrown.com>
Signed-off-by: Vincent Duvert <vincent.ldev@...ert.net>
[lukas: add missing tags]
Signed-off-by: Lukas Wunner <lukas@...ner.de>
Cc: stable@...r.kernel.org # v5.1+
Cc: Yue Haibing <yuehaibing@...wei.com>
---
 net/appletalk/atalk_proc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/appletalk/atalk_proc.c b/net/appletalk/atalk_proc.c
index 550c6ca..9c12412 100644
--- a/net/appletalk/atalk_proc.c
+++ b/net/appletalk/atalk_proc.c
@@ -229,6 +229,8 @@ int __init atalk_proc_init(void)
 				     sizeof(struct aarp_iter_state), NULL))
 		goto out;
 
+	return 0;
+
 out:
 	remove_proc_subtree("atalk", init_net.proc_net);
 	return -ENOMEM;
-- 
2.27.0