lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 2 Aug 2020 07:06:51 +0200
From:   Lukas Wunner <>
To:     David Miller <>,
        Jakub Kicinski <>
Cc:     Vincent Duvert <>,
        Christopher KOBAYASHI <>,
        Doug Brown <>,
        Yue Haibing <>,
Subject: [PATCH] appletalk: Fix atalk_proc_init() return path

From: Vincent Duvert <>

Add a missing return statement to atalk_proc_init so it doesn't return
-ENOMEM when successful.  This allows the appletalk module to load

Fixes: e2bcd8b0ce6e ("appletalk: use remove_proc_subtree to simplify procfs code")
Reported-by: Christopher KOBAYASHI <>
Reported-by: Doug Brown <>
Signed-off-by: Vincent Duvert <>
[lukas: add missing tags]
Signed-off-by: Lukas Wunner <>
Cc: # v5.1+
Cc: Yue Haibing <>
 net/appletalk/atalk_proc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/appletalk/atalk_proc.c b/net/appletalk/atalk_proc.c
index 550c6ca..9c12412 100644
--- a/net/appletalk/atalk_proc.c
+++ b/net/appletalk/atalk_proc.c
@@ -229,6 +229,8 @@ int __init atalk_proc_init(void)
 				     sizeof(struct aarp_iter_state), NULL))
 		goto out;
+	return 0;
 	remove_proc_subtree("atalk", init_net.proc_net);
 	return -ENOMEM;

Powered by blists - more mailing lists