netdev - Re: [PATCH bpf-next] selftests/bpf: fix spurious test failures in core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 1 Aug 2020 23:20:47 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     John Fastabend <john.fastabend@...il.com>
Cc:     Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next] selftests/bpf: fix spurious test failures in
 core_retro selftest

On Fri, Jul 31, 2020 at 2:55 PM John Fastabend <john.fastabend@...il.com> wrote:
>
> Andrii Nakryiko wrote:
> > core_retro selftest uses BPF program that's triggered on sys_enter
> > system-wide, but has no protection from some unrelated process doing syscall
> > while selftest is running. This leads to occasional test failures with
> > unexpected PIDs being returned. Fix that by filtering out all processes that
> > are not test_progs process.
> >
> > Fixes: fcda189a5133 ("selftests/bpf: Add test relying only on CO-RE and no recent kernel features")
> > Signed-off-by: Andrii Nakryiko <andriin@...com>
> > ---
>
> Acked-by: John Fastabend <john.fastabend@...il.com>

Applied. Thanks