netdev - Re: [PATCH 1/2] ipw2100: Use GFP_KERNEL instead of GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200802151925.81F7EC433C9@smtp.codeaurora.org>
Date:   Sun,  2 Aug 2020 15:19:25 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     stas.yakovlev@...il.com, davem@...emloft.net, kuba@...nel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH 1/2] ipw2100: Use GFP_KERNEL instead of GFP_ATOMIC in some
 memory allocation

Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:

> The call chain is:
>    ipw2100_pci_init_one            (the probe function)
>      --> ipw2100_queues_allocate
>        --> ipw2100_tx_allocate
> 
> No lock is taken in the between.
> So it is safe to use GFP_KERNEL in 'ipw2100_tx_allocate()'.
> 
> BTW, 'ipw2100_queues_allocate()' also calls 'ipw2100_msg_allocate()' which
> already allocates some memory using GFP_KERNEL.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

2 patches applied to wireless-drivers-next.git, thanks.

9130559cf8db ipw2100: Use GFP_KERNEL instead of GFP_ATOMIC in some memory allocation
e52525c0c320 ipw2x00: switch from 'pci_' to 'dma_' API

-- 
https://patchwork.kernel.org/patch/11678101/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches