netdev - Re: [PATCH v4 06/11] net: dsa: microchip: ksz8795: change drivers prefix to be generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200803084247.23ceb0ed@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 3 Aug 2020 08:42:47 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michael Grzeschik <m.grzeschik@...gutronix.de>
Cc:     andrew@...n.ch, netdev@...r.kernel.org, f.fainelli@...il.com,
        davem@...emloft.net, kernel@...gutronix.de
Subject: Re: [PATCH v4 06/11] net: dsa: microchip: ksz8795: change drivers
 prefix to be generic

On Mon,  3 Aug 2020 07:44:37 +0200 Michael Grzeschik wrote:
> The driver can be used on other chips of this type. To reflect
> this we rename the drivers prefix from ksz8795 to ksz8.
> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@...gutronix.de>

allmodconfig:

../drivers/net/dsa/microchip/ksz8795.c:415:41: error: using member 'shifts' in incomplete struct ksz8
../drivers/net/dsa/microchip/ksz8795.c:802:46: warning: incorrect type in argument 3 (different type sizes)
../drivers/net/dsa/microchip/ksz8795.c:802:46:    expected unsigned int [usertype] *vlan
../drivers/net/dsa/microchip/ksz8795.c:802:46:    got unsigned short *
../drivers/net/dsa/microchip/ksz8795.c:843:46: warning: incorrect type in argument 3 (different type sizes)
../drivers/net/dsa/microchip/ksz8795.c:843:46:    expected unsigned int [usertype] *vlan
../drivers/net/dsa/microchip/ksz8795.c:843:46:    got unsigned short *
../drivers/net/dsa/microchip/ksz8795.c: In function ‘ksz8_r_vlan_entries’:
../drivers/net/dsa/microchip/ksz8795.c:415:34: error: invalid use of undefined type ‘struct ksz8’
  415 |  struct ksz_shifts *shifts = ksz8->shifts;
      |                                  ^~
../drivers/net/dsa/microchip/ksz8795.c:415:21: warning: unused variable ‘shifts’ [-Wunused-variable]
  415 |  struct ksz_shifts *shifts = ksz8->shifts;
      |                     ^~~~~~
../drivers/net/dsa/microchip/ksz8795.c: In function ‘ksz8_port_vlan_add’:
../drivers/net/dsa/microchip/ksz8795.c:802:31: error: passing argument 3 of ‘ksz8_r_vlan_table’ from incompatible pointer type [-Werror=incompatible-pointer-types]
  802 |   ksz8_r_vlan_table(dev, vid, &data);
      |                               ^~~~~
      |                               |
      |                               u16 * {aka short unsigned int *}
../drivers/net/dsa/microchip/ksz8795.c:427:69: note: expected ‘u32 *’ {aka ‘unsigned int *’} but argument is of type ‘u16 *’ {aka ‘short unsigned int *’}
  427 | static void ksz8_r_vlan_table(struct ksz_device *dev, u16 vid, u32 *vlan)
      |                                                                ~~~~~^~~~
../drivers/net/dsa/microchip/ksz8795.c: In function ‘ksz8_port_vlan_del’:
../drivers/net/dsa/microchip/ksz8795.c:843:31: error: passing argument 3 of ‘ksz8_r_vlan_table’ from incompatible pointer type [-Werror=incompatible-pointer-types]
  843 |   ksz8_r_vlan_table(dev, vid, &data);
      |                               ^~~~~
      |                               |
      |                               u16 * {aka short unsigned int *}
../drivers/net/dsa/microchip/ksz8795.c:427:69: note: expected ‘u32 *’ {aka ‘unsigned int *’} but argument is of type ‘u16 *’ {aka ‘short unsigned int *’}
  427 | static void ksz8_r_vlan_table(struct ksz_device *dev, u16 vid, u32 *vlan)
      |                                                                ~~~~~^~~~
cc1: some warnings being treated as errors
make[5]: *** [../scripts/Makefile.build:281: drivers/net/dsa/microchip/ksz8795.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [../scripts/Makefile.build:497: drivers/net/dsa/microchip] Error 2
make[3]: *** [../scripts/Makefile.build:497: drivers/net/dsa] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [../scripts/Makefile.build:497: drivers/net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/netdev/net-next/Makefile:1771: drivers] Error 2