netdev - Re: [PATCH net-next] mptcp: use mptcp_for_each_subflow in mptcp_stream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23193e12ae89515e3044862a5596576b02766378.camel@redhat.com>
Date:   Mon, 03 Aug 2020 18:42:48 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Geliang Tang <geliangtang@...il.com>,
        Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        Matthieu Baerts <matthieu.baerts@...sares.net>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, mptcp@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] mptcp: use mptcp_for_each_subflow in
 mptcp_stream_accept

On Mon, 2020-08-03 at 21:00 +0800, Geliang Tang wrote:
> Use mptcp_for_each_subflow in mptcp_stream_accept instead of
> open-coding.
> 
> Signed-off-by: Geliang Tang <geliangtang@...il.com>
> ---
>  net/mptcp/protocol.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
> index d3fe7296e1c9..400824eabf73 100644
> --- a/net/mptcp/protocol.c
> +++ b/net/mptcp/protocol.c
> @@ -2249,7 +2249,7 @@ static int mptcp_stream_accept(struct socket *sock, struct socket *newsock,
>  		 * This is needed so NOSPACE flag can be set from tcp stack.
>  		 */
>  		__mptcp_flush_join_list(msk);
> -		list_for_each_entry(subflow, &msk->conn_list, node) {
> +		mptcp_for_each_subflow(msk, subflow) {
>  			struct sock *ssk = mptcp_subflow_tcp_sock(subflow);
>  
>  			if (!ssk->sk_socket)

Acked-by: Paolo Abeni <pabeni@...hat.com>